Changeset 667

Timestamp:

11/09/06 13:47:36 (4 years ago)

Author:

emanuel

Message:

code style

Location:

Jupe/src/org/jupe

Files:

• editors/classdiagram/model/nodes/MethodElement.java (modified) (1 diff)
• plugin/JupeLog.java (modified) (1 diff)
• uml2model/UML2ModelRoot.java (modified) (4 diffs)

Jupe/src/org/jupe/editors/classdiagram/model/nodes/MethodElement.java

@@ -38 +38 @@
 import org.jupe.editors.classdiagram.model.validators.ParameterListValidator;
 import org.jupe.editors.classdiagram.model.validators.TypeNameValidator;
-import org.jupe.plugin.JupeLog;
 import org.jupe.plugin.exceptions.JupeExceptionLogOnly;
 import org.jupe.synchronisation.Util;

Jupe/src/org/jupe/plugin/JupeLog.java

@@ -80 +80 @@
                 logList.add(message);
                 if (shouldBePrinted) {
-                        System.out.println("[debug] " + message);
+                        System.out.println(new StringBuffer("[debug] ").append(message));
                 }
         }

Jupe/src/org/jupe/uml2model/UML2ModelRoot.java

@@ -237 +237 @@
                 // .uml2
                 // files for synchronization
-                String id;
+                StringBuffer id;
 
                 if (isConnection(element)) {
-                        id = element.getClass().getSimpleName() + "_" + element.hashCode()
-                                        + "_" + System.currentTimeMillis();
+                        id = new StringBuffer(element.getClass().getSimpleName());
+                        id.append("_");
+                        id.append(element.hashCode());
+                        id.append("_");
+                        id.append(System.currentTimeMillis());
                 } else if (element instanceof NamedElement) {
-                        id = getAbsoluteName((NamedElement) element) + "_"
-                                        + element.hashCode();
+                        id = new StringBuffer(getAbsoluteName((NamedElement) element));
+                        id.append("_");
+                        id.append(element.hashCode());
                 } else {
-                        id = "unnamed_element_" + element.hashCode();
-                }
-                addToIDHash(id, element);
+                        id = new StringBuffer("unnamed_element_")
+                                        .append(element.hashCode());
+                }
+                addToIDHash(id.toString(), element);
         }
 
@@ -294 +299 @@
          *         hidden packages and noHiddenPackage is true.
          */
-        public String getAbsoluteName(NamedElement element,
+        public String getAbsoluteName(final NamedElement element,
                         final boolean noHiddenPackages) {
                 if (element.equals(model)) {
@@ -314 +319 @@
                 }
 
-                while (((element = (NamedElement) element.getOwner()) != null)
-                                && !element.equals(model)) {
-                        name = element.getName() + "." + name;
+                // old code: does the new one work?
+                /*
+                 * while (((element = (NamedElement) element.getOwner()) != null) &&
+                 * !element.equals(model)) { name = element.getName() + "." + name; }
+                 */
+
+                NamedElement tempElement = element;
+
+                while (true) {
+                        tempElement = (NamedElement) tempElement.getOwner();
+                        if (tempElement == null || tempElement.equals(model)) {
+                                break;
+                        }
+                        name = new StringBuffer(tempElement.getName()).append(".").append(
+                                        name).toString();
                 }
 
@@ -617 +634 @@
                         if (!(structuralFeature.getFeatureID() == UMLPackage.TYPED_ELEMENT__TYPE || structuralFeature
                                         .getFeatureID() == UMLPackage.INSTANCE_SPECIFICATION__CLASSIFIER)) {
-                                JupePlugin.getDefault().println(
-                                                "Skipping feature " + structuralFeature.getName()
-                                                                + " (" + structuralFeature.getFeatureID()
-                                                                + ") " + " while searching references to type");
+                                JupePlugin
+                                                .getDefault()
+                                                .println(
+                                                                new StringBuffer("Skipping feature ")
+                                                                                .append(structuralFeature.getName())
+                                                                                .append(" (")
+                                                                                .append(
+                                                                                                structuralFeature
+                                                                                                                .getFeatureID())
+                                                                                .append(
+                                                                                                ") while searching references to type"));
                                 continue;
                         }